netdev - Re: [PATCH] bnx2x: dont dereference tcp header on non tcp frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110421.172011.102558889.davem@davemloft.net>
Date:	Thu, 21 Apr 2011 17:20:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	eric.dumazet@...il.com, eilong@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bnx2x: dont dereference tcp header on non tcp frames

From: "Dmitry Kravkov" <dmitry@...adcom.com>
Date: Wed, 20 Apr 2011 12:40:10 +0300

> On Wed, 2011-04-20 at 01:46 -0700, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Wed, 20 Apr 2011 09:31:53 +0200
>> 
>> > [PATCH] bnx2x: dont dereference tcp header on non tcp frames
>> > 
>> > bnx2x_set_pbd_csum() & bnx2x_set_pbd_csum_e2() use 
>> > tcp_hdrlen(skb) even for non TCP frames
>> > 
>> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
>> 
>> Broadcom folks please review.
>> 
> 
> Following patch fixes udp checksum offload flow and also addresses
> issues raised by Eric. We are testing it now.
> 
> From: Vladislav Zolotarov <vladz@...adcom.com>
> 
> Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

Can you guys please wrap this up and formally submit this patch?

Please remember to add appropriate tags for Eric, probably both
"Reported-by: " and "Tested-by: ".

Thank you!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html