netdev - Re: [PATCH v4] net: fix hw_features ethtool_ops->set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110421.172159.179943760.davem@davemloft.net>
Date:	Thu, 21 Apr 2011 17:21:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mirq-linux@...e.qmqm.pl
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	eric.dumazet@...il.com, vladz@...adcom.com, eilong@...adcom.com
Subject: Re: [PATCH v4] net: fix hw_features ethtool_ops->set_flags
 compatibility

From: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
Date: Fri, 22 Apr 2011 01:59:21 +0200 (CEST)

> __ethtool_set_flags() was not taking into account features set but not
> user-toggleable.
> 
> Since GFLAGS returns masked dev->features, EINVAL is returned when
> passed flags differ to it, and not to wanted_features.
> 
> Signed-off-by: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
> ---
> This should be the simpler way Ben was talking about.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html