lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Apr 2011 08:59:16 +0800 From: Wei Yongjun <yjwei@...fujitsu.com> To: David Miller <davem@...emloft.net> CC: netdev@...r.kernel.org, linux-sctp@...r.kernel.org Subject: Re: [PATCH net-next-2.6 0/7] SCTP updates for net-next-2.6 > Wei, while you are re-spinning this patch set I want to bring up > something I just noticed in the SCTP code. > > The ->dst_saddr() method is not used by anything, it appears. > > The ipv4 variant, sctp_v4_dst_saddr() is called internally by the > ipv4 specific code, but that's it. > > So I think the ->dst_saddr member of sctp_pf can be completely > removed, as can sctp_v6_dst_saddr(). > > The sctp_v4_dst_saddr() function, of course, will need to be retained. David, thanks to noticed this. I will cleanup it. And I have a stupid question about the rule of backport. Since those patchs have existed so long time, when I backport those patchs, I'd better fix the bug in the original patch, or create new patch to fix it? Also how about some thing need to improvement like the ->dst_saddr() method? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists