[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110427125201.18395e2f@lxorguk.ukuu.org.uk>
Date: Wed, 27 Apr 2011 12:52:01 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: Lifeng Sun <lifongsun@...il.com>, linux-kernel@...r.kernel.org,
netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] Applying inappropriate ioctl operation on socket should
return ENOTTY
> Well, I wont argue the point, especially if you Ack the changes ;)
>
> My only concern was to not break old applications, I dont know if it is
> going to break _any_ of them. Probably these old applications stick with
> old kernels.
The number of applications that actually check ioctl error codes beyond
if error perror; return is pretty small and those that do generally do so
for very narrow cases or for things like EWOULDBLOCK/EINTR stuff.
> If you ask me ENOTTY is plain wrong.
> ioctl() is not restricted to terminal devices at all.
Like the tab/space thing in Makefiles and Qwerty keyboards its now part of
how stuff all works but EINVAL is even worse because you cannot tell
between 'this ioctl isn't know/is used on the wrong fd' and 'argument
wrong to valid ioctl'
Alan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists