netdev - Re: [PATCHv2 2/2] tg3: Add code to allow ethtool to enable/disable loopback.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1304317743.7792.24.camel@Joe-Laptop>
Date:	Sun, 01 May 2011 23:29:03 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	Matt Carlson <mcarlson@...adcom.com>,
	netdev <netdev@...r.kernel.org>,
	Michael Chan <mchan@...adcom.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Subject: Re: [PATCHv2 2/2] tg3: Add code to allow ethtool to enable/disable
 loopback.

On Fri, 2011-04-29 at 18:03 -0700, Mahesh Bandewar wrote:
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

trivia:

>  drivers/net/tg3.c |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++
[]
> @@ -15241,6 +15288,16 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
>  	dev->features |= hw_features;
>  	dev->vlan_features |= hw_features;
>  
> +	/*
> +	 * Add loopback capability only for a subset of devices that support
> +	 * MAC-LOOPBACK. Eventually this need to be enhanced to allow INT-PHY
> +	 * loopback for the remaining devices.
> +	 */
> +	if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5780 ||
> +			!tg3_flag(tp, CPMU_PRESENT))

The indentation style is a bit out of character for the file.
Aligned to open parenthesis is the style used elsewhere:

	if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5780 ||
	    !tg3_flag(tp, CPMU_PRESENT))

like this:

>  	if (tp->pci_chip_rev_id == CHIPREV_ID_5705_A1 &&
>  	    !tg3_flag(tp, TSO_CAPABLE) &&
>  	    !(tr32(TG3PCI_PCISTATE) & PCISTATE_BUS_SPEED_HIGH)) {



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html