netdev - Re: [PATCH V2] net/stmmac: Move "#include <linux/platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DBF9477.5070302@st.com>
Date:	Tue, 03 May 2011 07:36:55 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, shiraz.hashim@...com,
	armando.visconti@...com, deepak.sikri@...com,
	viresh.linux@...il.com
Subject: Re: [PATCH V2] net/stmmac: Move "#include <linux/platform_device.h>"
 to linux/stmmac.h

On 5/3/2011 6:36 AM, Viresh Kumar wrote:
> stmmac.h uses struct platform_device and doesn't include
> <linux/platform_device.h>. Whereas drivers/net/stmmac/stmmac.h includes it, but
> doesn't directly use it. And so we get following compilation warning while using
> this file:
> 	warning: ‘struct platform_device’ declared inside parameter list
> 
> This patch includes <linux/platform_device.h> in linux/stmmac.h and removes it
> from drivers/net/stmmac/stmmac.h
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...com>

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

> ---
>  drivers/net/stmmac/stmmac.h |    1 -
>  include/linux/stmmac.h      |    2 ++
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/stmmac/stmmac.h b/drivers/net/stmmac/stmmac.h
> index 5f06c47..2b076b3 100644
> --- a/drivers/net/stmmac/stmmac.h
> +++ b/drivers/net/stmmac/stmmac.h
> @@ -21,7 +21,6 @@
>  *******************************************************************************/
>  
>  #define DRV_MODULE_VERSION	"Nov_2010"
> -#include <linux/platform_device.h>
>  #include <linux/stmmac.h>
>  
>  #include "common.h"
> diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
> index f29197a..9529e49 100644
> --- a/include/linux/stmmac.h
> +++ b/include/linux/stmmac.h
> @@ -26,6 +26,8 @@
>  #ifndef __STMMAC_PLATFORM_DATA
>  #define __STMMAC_PLATFORM_DATA
>  
> +#include <linux/platform_device.h>
> +
>  /* platform data for platform device structure's platform_data field */
>  
>  /* Private data for the STM on-board ethernet driver */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html