netdev - Re: [PATCH V2] net/stmmac: Move "#include <linux/platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 May 2011 16:09:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	viresh.kumar@...com, netdev@...r.kernel.org, shiraz.hashim@...com,
	armando.visconti@...com, deepak.sikri@...com,
	viresh.linux@...il.com
Subject: Re: [PATCH V2] net/stmmac: Move "#include
 <linux/platform_device.h>" to linux/stmmac.h

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Tue, 03 May 2011 07:36:55 +0200

> On 5/3/2011 6:36 AM, Viresh Kumar wrote:
>> stmmac.h uses struct platform_device and doesn't include
>> <linux/platform_device.h>. Whereas drivers/net/stmmac/stmmac.h includes it, but
>> doesn't directly use it. And so we get following compilation warning while using
>> this file:
>> 	warning: ‘struct platform_device’ declared inside parameter list
>> 
>> This patch includes <linux/platform_device.h> in linux/stmmac.h and removes it
>> from drivers/net/stmmac/stmmac.h
>> 
>> Signed-off-by: Viresh Kumar <viresh.kumar@...com>
> 
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

Applied to net-next-2.6, thanks everyone.