netdev - Re: [net-next 4/5] bnx2x: improve memory handling, low memory recovery flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 May 2011 16:07:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	netdev@...r.kernel.org, eilong@...adcom.com
Subject: Re: [net-next 4/5] bnx2x: improve memory handling, low memory
 recovery flows

From: "Dmitry Kravkov" <dmitry@...adcom.com>
Date: Tue, 3 May 2011 16:28:57 +0300

>  
> +/**
> + * zeros the contents of the bp->fp[index].
> + * Makes sure the contents of the bp->fp[index]. napi is kept
> + * intact.
> + *
> + * @param bp
> + * @param index
> + */

I should have caught this in the past but I've only noticed it right
now.

Do not use your own, custom, format for documenting functions and
their arguments.

Use the standard DocBook comment format we use in the entire kernel.

The last thing we need is every single driver using their own custom
format.

Fix up the existing cases, or remove them completely.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html