netdev - Re: [net-next 1/5] bnx2x: link report improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110503.160508.226773770.davem@davemloft.net>
Date:	Tue, 03 May 2011 16:05:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	netdev@...r.kernel.org, vladz@...adcom.com, eilong@...adcom.com
Subject: Re: [net-next 1/5] bnx2x: link report improvements

From: "Dmitry Kravkov" <dmitry@...adcom.com>
Date: Tue, 3 May 2011 16:38:45 +0300

> From: Vladislav Zolotarov <vladz@...adcom.com>
> 
> To avoid link notification duplications
> 
> Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> Signed-off-by: Vladislav Zolotarov <vladz@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>

You go through all of the effort to use atomic bit operations
on the link state statue flags, then do a memcpy() to propagate
new state into the software state structure which is not atomic.

Either it needs to be atomic or it does not.

If it doesn't use __set_bit() and friends and document exactly
what synchronizes and protects access to this object.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html