netdev - Re: bug fix for out-of-tree igb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimdJr98ZbgxpfzqAS-w+MiyKSw-UA@mail.gmail.com>
Date:	Wed, 4 May 2011 11:12:56 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Ben Greear <greearb@...delatech.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: bug fix for out-of-tree igb driver

On Wed, May 4, 2011 at 11:06, Ben Greear <greearb@...delatech.com> wrote:
> Just in case someone is using the out-of-tree igb driver, I
> think I found a bug.
>
> The tx_queue_mapping method should have r_idx >= adapter->num_tx_queues
> as shown below.  The driver had: r_idx > adapter->num_tx_queues originally.
>
> Its possible my code is buggy for sending queue_mapping of 1
> when num_tx_queues is 1, but either way, the driver
> shouldn't crash.
>
> Upstream igb driver in mainline kernels does not have this problem.
>
> static inline struct igb_ring *igb_tx_queue_mapping(struct igb_adapter
> *adapter,
>                                                    struct sk_buff *skb)
> {
>        unsigned int r_idx = skb->queue_mapping & (IGB_MAX_TX_QUEUES - 1);
>
>        if (r_idx >= adapter->num_tx_queues)
>                r_idx = r_idx % adapter->num_tx_queues;
>
>        return adapter->tx_ring[r_idx];
> }
>
> Thanks,
> Ben
>

Thanks Ben, I have copied Carolyn so that she is aware of it.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html