netdev - RE: [ethtool PATCH] FW dump support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49395329523DD64492581B505F80C86D5A5BCD3990@EXMAIL.ad.emulex.com>
Date:	Wed, 4 May 2011 11:15:59 -0700
From:	<Ajit.Khaparde@...lex.Com>
To:	<anirban.chakraborty@...gic.com>
CC:	<netdev@...r.kernel.org>, <--no-chain-reply-to@...qlogic.com>,
	<davem@...emloft.net>, <bhutchings@...arflare.com>
Subject: RE: [ethtool PATCH] FW dump support

________________________________________
From: netdev-owner@...r.kernel.org [netdev-owner@...r.kernel.org] On Behalf Of Ben Hutchings [bhutchings@...arflare.com]
Sent: Wednesday, May 04, 2011 12:40 PM
To: anirban.chakraborty@...gic.com
Cc: netdev@...r.kernel.org; --no-chain-reply-to@...qlogic.com; davem@...emloft.net
Subject: Re: [ethtool PATCH] FW dump support

> On Mon, 2011-05-02 at 16:29 -0700, anirban.chakraborty@...gic.com wrote:
>> From: Anirban Chakraborty <anirban.chakraborty@...gic.com>
>>
>> Added support to take FW dump via ethtool.
> [...]
>> --- a/ethtool.c
>> +++ b/ethtool.c
> [...]
>> @@ -263,6 +270,12 @@ static struct option {
>>               "Get Rx ntuple filters and actions\n" },
>>      { "-P", "--show-permaddr", MODE_PERMADDR,
>>               "Show permanent hardware address" },
>> +    { "-W", "--get-dump", MODE_GET_DUMP,
>> +             "Get dump level\n" },
>> +    { "-Wd", "--get-dump-data", MODE_GET_DUMP_DATA,
>> +             "Get dump data", "FILENAME " "Name of the dump file\n" },
>
> The short options should only include one letter.  Also the general
> pattern is that 'get' options use lower-case letters and 'set' options
> use upper-case letters.  No, I'm not sure how best to handle a set of 3
> options.  Maybe you can combine --get-dump and --get-dump-data, making
> the filename optional?

ethtool already has "-f" option to flash/write the FW image.
Can you use "-F" to get the FW dump data out?
And then may be, these options can be extended to get the get/set dump levels?

-Ajit--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html