netdev - Re: [Pv-drivers] [PATCH] vmxnet3: Consistently disable irqs when taking adapter->cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110506.131211.39193090.davem@davemloft.net>
Date:	Fri, 06 May 2011 13:12:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	scottjg@...are.com
Cc:	sbhatewara@...are.com, roland@...nel.org, pv-drivers@...are.com,
	netdev@...r.kernel.org
Subject: Re: [Pv-drivers] [PATCH] vmxnet3: Consistently disable irqs when
 taking adapter->cmd_lock

From: Scott Goldman <scottjg@...are.com>
Date: Fri, 6 May 2011 13:10:29 -0700

>> 
>> On Fri, 6 May 2011, Roland Dreier wrote:
>> 
>> > From: Roland Dreier <roland@...estorage.com>
>> >
>> > Using the vmxnet3 driver produces a lockdep warning because
>> 
>> > Signed-off-by: Roland Dreier <roland@...estorage.com>
>> 
>> 
>> Roland, thanks for the analysis and the patch.
>> 
>> Signed-off-by: Shreyas N Bhatewara <sbhatewara@...are.com>
> 
> Likewise, seems pretty sane to me. The command register operations are only control-path operations and disabling interrupts for the duration is probably not a big deal. Touching the cmd reg will result a VMEXIT, where the guest won't be processing interrupts anyway. 
> 
> Signed-off-by: Scott J. Goldman <scottjg@...are.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html