lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 06 May 2011 13:21:29 -0700 (PDT) From: David Miller <davem@...emloft.net> To: netdev@...r.kernel.org Cc: vladislav.yasevich@...com, yjwei@...fujitsu.com, jchapman@...alix.com Subject: Re: ip_queue_xmit() used illegally From: David Miller <davem@...emloft.net> Date: Fri, 06 May 2011 12:26:56 -0700 (PDT) > SCTP stores it's binding information using transports and assosciations > and does not fill in the ->inet_{daddr,saddr} values. > > It tries to work around this route issue by checking dst->obsolete > directly in sctp_packet_transmit(), which just makes the race smaller > and does not eliminate it. ip_queue_xmit() can still end up with > __sk_dst_check() returning NULL and then we end up emitting a > potentially bogus packet. I take this back, we added this hack where things like SCTP can pre-route the packet by hooking up the route to the SKB before calling ->queue_xmit. And L2TP does something similar. So false alarm, nothing to see here :-) I still want to clean this up so that this kind of stuff can be handled generically inside of ->queue_xmit() by passing in the correct addressing information. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists