netdev - Re: [RFC V2 PATCH] rtnetlink: Add method to calculate dump info data size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1305000182.3050.50.camel@edumazet-laptop>
Date:	Tue, 10 May 2011 06:03:02 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Greg Rose <gregory.v.rose@...el.com>, netdev@...r.kernel.org,
	bhutchings@...arflare.com, davem@...emloft.net
Subject: Re: [RFC V2 PATCH] rtnetlink: Add method to calculate dump info
 data size

Le lundi 09 mai 2011 à 20:56 -0700, Stephen Hemminger a écrit :
> What happens is dump iterates over the table and puts entries into
> skb. When space is exhausted in skb the iterator stops and records the
> key of the where to restart.

Exactly : We would increase min_dump_alloc at this point, and not fully
recompute it at each round ;)

Problem is we could return an empty answer if first device ever dumped
in "ip link" would be a 'large one' and min_dump_alloc not yet
increased, so "ip link" would consider table is empty ?

Thats why I suggested to increase min_dump_alloc() when bloated^W driver
is loaded.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html