netdev - Re: [PATCH net-next] netdevice.h: Align struct netdevices members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1305001325.19586.110.camel@Joe-Laptop>
Date:	Mon, 09 May 2011 21:22:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] netdevice.h: Align struct netdevices members

On Tue, 2011-05-10 at 05:53 +0200, Eric Dumazet wrote:
> Le lundi 09 mai 2011 à 20:42 -0700, Joe Perches a écrit :
> > Save a bit of space.
> Hmm... correct alignements are far more important for this structure.

I agree.  I aligned these members on "natural" boundaries.
4 consecutive chars rather than 2 chars, unsigned long.
 
> Did you run benchmarks on 32bit and 64bit platforms ?

Nope.

> BTW we have ____cacheline_aligned_in_smp markers, I am not even sure
> this patch saves space.

That depends on whether or not CONFIG_SMP is defined and
all of the changes are before any ____cacheline_aligned markers.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html