[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4DCC1372.3040607@chelsio.com>
Date: Thu, 12 May 2011 10:05:54 -0700
From: Dimitris Michailidis <dm@...lsio.com>
To: Shan Wei <shanwei@...fujitsu.com>
CC: David Miller <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>, eilong@...adcom.com,
leedom@...lsio.com
Subject: Re: [PATCH net-next 1/2 RESEND v3] net: use NETIF_F_ALL_TSO for vlan
features
On 05/12/2011 02:54 AM, Shan Wei wrote:
> Dimitris Michailidis wrote, at 2011年05月12日 00:35:
>> On 05/10/2011 11:24 PM, Shan Wei wrote:
>>> As Dimitris Michailidis suggested, use NETIF_F_ALL_TSO for vlan_features,
>>> which is a mask, but not hw_features.
>>>
>>> Signed-off-by: Shan Wei <shanwei@...fujitsu.com>
>> While these changes aren't wrong I don't see a good reason to make them. I am also curious why you're changing only these three drivers.
>
> A personal reason to quickly know what device supports ALL TSO,
> not to search one by one. :;)
But vlan_features doesn't indicate by itself what the device supports, and it
is because of this that you can use NETIF_F_ALL_TSO in vlan_features without
much future breakage risk. There's still the potential that in the future some
additional TSO variant will be added that some of the drivers you're changing
support, but not over VLANs, and then they'll need to undo you change.
If you want to know which drivers support all TSOs you really need to look at
their features and hw_features. One could set NETIF_F_ALL_TSO in vlan_features
of a driver that doesn't support any form of TSO. The way you're checking
you'd be misled into thinking that driver supports all TSO.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists