netdev - Re: [PATCH net-next 1/2 RESEND v3] net: use NETIF_F_ALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DCBAE3B.3070201@cn.fujitsu.com>
Date:	Thu, 12 May 2011 17:54:03 +0800
From:	Shan Wei <shanwei@...fujitsu.com>
To:	Dimitris Michailidis <dm@...lsio.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, eilong@...adcom.com,
	leedom@...lsio.com
Subject: Re: [PATCH net-next 1/2 RESEND v3] net: use NETIF_F_ALL_TSO for vlan
 features

Dimitris Michailidis wrote, at 2011年05月12日 00:35:
> On 05/10/2011 11:24 PM, Shan Wei wrote:
>> As Dimitris Michailidis suggested, use NETIF_F_ALL_TSO for vlan_features,
>> which is a mask, but not hw_features.
>>
>> Signed-off-by: Shan Wei <shanwei@...fujitsu.com>
> 
> While these changes aren't wrong I don't see a good reason to make them.  I am also curious why you're changing only these three drivers.

A personal reason to quickly know what device supports ALL TSO,
not to search one by one. :;)

TSO offloads are assigned directly in these three drivers.
Other drivers set vlan_features as hw_features, or set TSO offloads after doing some check.

-- 
Best Regards
-----
Shan Wei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html