netdev - Re: [PATCH net-next] ethtool: bring back missing comma in netdev_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DCBA4C5.5040308@lastsummer.de>
Date:	Thu, 12 May 2011 11:13:41 +0200
From:	Franco Fichtner <franco@...tsummer.de>
To:	Michał Mirosław <mirqus@...il.com>
CC:	Franco Fichtner <franco@...tsummer.de>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings

On 12/05/11 10:55, Michał Mirosław wrote:
> 2011/5/12 Franco Fichtner <franco@...tsummer.de>:
>> I found this while skimming through recent net-next patches.
>> I'm not quite sure if the padding in this struct is correct now.
> Nice catch. But please send the patch inline instead of as an attachment.

Thanks, but I have a short question. Are the empty strings in
this struct really needed?

        /* NETIF_F_TSO6 */            "tx-tcp6-segmentation",
        /* NETIF_F_FSO */             "tx-fcoe-segmentation",
        "",
        "",

        /* NETIF_F_FCOE_CRC */        "tx-checksum-fcoe-crc",

They seem to have caused this mess in the first place and I would
think they could be removed entirely.

I will resend the patch later today as inline. Sorry about that.


Franco
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html