netdev - Re: [PATCH net-next] ethtool: bring back missing comma in netdev_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTimVw0yGSexP6goH+hTtzkwBudHKTQ@mail.gmail.com>
Date:	Thu, 12 May 2011 13:33:21 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	Franco Fichtner <franco@...tsummer.de>
Cc:	Netdev <netdev@...r.kernel.org>,
	Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings

W dniu 12 maja 2011 11:13 użytkownik Franco Fichtner
<franco@...tsummer.de> napisał:
> On 12/05/11 10:55, Michał Mirosław wrote:
>> 2011/5/12 Franco Fichtner <franco@...tsummer.de>:
>>> I found this while skimming through recent net-next patches.
>>> I'm not quite sure if the padding in this struct is correct now.
>> Nice catch. But please send the patch inline instead of as an attachment.
> Thanks, but I have a short question. Are the empty strings in
> this struct really needed?
>
>        /* NETIF_F_TSO6 */            "tx-tcp6-segmentation",
>        /* NETIF_F_FSO */             "tx-fcoe-segmentation",
>        "",
>        "",
>
>        /* NETIF_F_FCOE_CRC */        "tx-checksum-fcoe-crc",
>
> They seem to have caused this mess in the first place and I would
> think they could be removed entirely.

Mahesh Bandewar tried to do some cleanup in how feature bits are
defined using an enum, but it wasn't completed. If that cleanup was
completed, this array could be initialized using C99 style:

  [NETIF_F_TSO6_BIT] = "tx-tcp6-segmentation",

(This has more advantages than pure aesthetics.) For now those empty
strings have to stay, as the array positions are relevant.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html