netdev - Re: [PATCH net-next-2.6] net/bonding: adjust codingstyle for bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110511172814.714e2f2a@nehalam>
Date:	Wed, 11 May 2011 17:28:14 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	aquini@...ux.com
Cc:	Jay Vosburgh <fubar@...ibm.com>, Joe Perches <joe@...ches.com>,
	kernel-janitors@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org,
	Nicolas Kaiser <nikai@...ai.net>
Subject: Re: [PATCH net-next-2.6] net/bonding: adjust codingstyle for
 bond_3ad files

On Wed, 11 May 2011 19:52:21 -0300
Rafael Aquini <aquini@...ux.com> wrote:

> Howdy,
> 
> While I was studying what bond_3ad has under its hood, I realized its coding
> style did not follow all Documentation/CodingStyle recommendations. As a tiny
> collaboration I did some mods there, in an attempt to make that code stick as
> closely as possible with Kernel's coding style. Also, Nicolas Kaiser has kindly
> suggested some conditional simplifications integrated in this patch.
> Modifications:
>         * switched all comments from C99-style to C89-style;
>         * replaced MAC_ADDRESS_COMPARE macro for compare_ether_addr();
> 	* print info out on unexpected status checkings;
>         * simplify conditionals:
> 		(a || (!a && !b)) => (a || !b)
> 		(!(!a && b)) => (a || !b)
> 
> Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
> Signed-off-by: Rafael Aquini <aquini@...ux.com>

This should be split into three separate patches.

Always assume your change will break something for somebody and it will
be necessary for some later investigation to bisect out the cause.



-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html