netdev - Re: [PATCH net-next-2.6] net/bonding: adjust codingstyle for bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110512004839.GB2435@x61.tchesoft.com>
Date:	Wed, 11 May 2011 21:48:41 -0300
From:	Rafael Aquini <aquini@...ux.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Jay Vosburgh <fubar@...ibm.com>, Joe Perches <joe@...ches.com>,
	kernel-janitors@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org,
	Nicolas Kaiser <nikai@...ai.net>
Subject: Re: [PATCH net-next-2.6] net/bonding: adjust codingstyle for bond_3ad
 files

Howdy Stephen,

On Wed, May 11, 2011 at 05:28:14PM -0700, Stephen Hemminger wrote:
> 
> This should be split into three separate patches.
> 
> Always assume your change will break something for somebody and it will
> be necessary for some later investigation to bisect out the cause.

I'd like to know what are your suggestios to split it.
1. patch for comments;
2. patch for simplification (Nicolas);
3. patch for other adjusts (macro replacement, uninitialized vars...)

Would this approach really be productive?

Thanks in advance.

Cheers!
-- 
Rafael Aquini <aquini@...ux.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html