netdev - Re: [PATCHv4 net-next-2.6] ethtool: Added support for FW dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110513.144001.1731111272250389970.davem@davemloft.net>
Date:	Fri, 13 May 2011 14:40:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	anirban.chakraborty@...gic.com, netdev@...r.kernel.org
Subject: Re: [PATCHv4 net-next-2.6] ethtool: Added support for FW dump

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Fri, 13 May 2011 00:05:07 +0100

> On Thu, 2011-05-12 at 15:48 -0700, Anirban Chakraborty wrote:
>> Added code to take FW dump via ethtool. Dump level can be controlled via setting the
>> dump flag. A get function is provided to query the current setting of the dump flag.
>> Dump data is obtained from the driver via a separate get function.
>> 
>> Changes from v3:
>> Fixed buffer length issue in ethtool_get_dump_data function.
>> Updated kernel doc for ethtool_dump struct and get_dump_flag function.
>> 
>> Changes from v2:
>> Provided separate commands for get flag and data.
>> Check for minimum of the two buffer length obtained via ethtool and driver and
>> use that for dump buffer
>> Pass up the driver return error codes up to the caller.
>> Added kernel doc comments.
>> 
>> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@...gic.com>
> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>
> 
> There is one tiny error I didn't notice before, which I think David can
> fix up if and when he applies this:

Applied with "u8/__u8" fixed up, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html