netdev - Re: [PATCH 2/2] forcedeth: allow to silence tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110518.171603.2048423328863525352.davem@davemloft.net>
Date:	Wed, 18 May 2011 17:16:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	decot@...gle.com
Cc:	joe@...ches.com, szymon@...c.net.pl, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-net-upstream@...gle.com,
	snanda@...gle.com
Subject: Re: [PATCH 2/2] forcedeth: allow to silence tx_timeout debug
 messages

From: David Decotigny <decot@...gle.com>
Date: Wed, 18 May 2011 14:10:00 -0700

> From: Sameer Nanda <snanda@...gle.com>
> 
> This change allows to silence most debug messages in case of TX
> timeout. These messages don't provide a signare/noise ratio high
> enough for production systems and, with ~30kB logged each time, they
> tend to add to a cascade effect if the system is already under stress
> (memory pressure, disk, etc.).
> 
> By default, the debug messages are not displayed but this can be
> overriden by setting the debug_tx_timeout module parameter.
> 
> 
> Signed-off-by: David Decotigny <decot@...gle.com>

I would rather you make the messages less verbose, instead of
having it say absolutely nothing when this happens as it is
a serious problem.

You can add a knob which when enabled gives the old verbosity
back for diagnostic purposes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html