| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1305819120.3271.3.camel@dcbw.foobar.com> Date: Thu, 19 May 2011 10:31:58 -0500 From: Dan Williams <dcbw@...hat.com> To: David Miller <davem@...emloft.net> Cc: micha@...i.hopto.org, netdev@...r.kernel.org Subject: Re: [PATCH v3] ipconfig wait for carrier On Wed, 2011-05-18 at 18:14 -0400, David Miller wrote: > From: Micha Nelissen <micha@...i.hopto.org> > Date: Wed, 18 May 2011 08:59:32 +0200 > > > Op 2011-05-18 8:37, David Miller schreef: > >> From: Micha Nelissen<micha@...i.hopto.org> > >> Date: Wed, 18 May 2011 08:32:35 +0200 > >> > >>> I'm confused. Against which tree/commit do you want it then? > >> > >> Linus's current tree would be fine as would: > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.git > > > > Ok I see, thanks. The patch should apply just fine to your tree, there > > is only a spelling change since 2.6.38 which does not conflict. > > Please fix ic_is_init_dev() to return a proper boolean "false" instead > of "0" when IFF_LOOPBACK is set. Shouldn't the code still wait at *least* one second? Not all drivers support carrier detect, and those that don't set the carrier always-on. Thus older devices that used to have 1s to get carrier in line (even if they don't report it) now have only 10ms. I think it should wait at least one second like the code currently does, and then if the carrier still isn't up, wait longer. Dan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists