netdev - RE: [RFC V4 PATCH] rtnetlink: Compute and store minimum ifinfo dump size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43F901BD926A4E43B106BF17856F0755018E321EB6@orsmsx508.amr.corp.intel.com>
Date:	Thu, 19 May 2011 08:35:33 -0700
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	"Rose, Gregory V" <gregory.v.rose@...el.com>,
	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: RE: [RFC V4 PATCH] rtnetlink: Compute and store minimum ifinfo dump
 size

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Rose, Gregory V
> Sent: Wednesday, May 18, 2011 3:49 PM
> To: David Miller
> Cc: netdev@...r.kernel.org; bhutchings@...arflare.com;
> eric.dumazet@...il.com
> Subject: RE: [RFC V4 PATCH] rtnetlink: Compute and store minimum ifinfo
> dump size
> 
> > -----Original Message-----
> > From: David Miller [mailto:davem@...emloft.net]
> > Sent: Wednesday, May 18, 2011 3:48 PM
> > To: Rose, Gregory V
> > Cc: netdev@...r.kernel.org; bhutchings@...arflare.com;
> > eric.dumazet@...il.com
> > Subject: Re: [RFC V4 PATCH] rtnetlink: Compute and store minimum ifinfo
> > dump size
> >
> > From: "Rose, Gregory V" <gregory.v.rose@...el.com>
> > Date: Wed, 18 May 2011 15:35:58 -0700
> >
> > > It looked to me like rtmsg_ifinfo is called when each device is
> > > registered through register_netdevice() and rtmsg_ifinfo in turn
> > > calls the if_nlmsg_size function returning the ifinfo dump size for
> > > each device.  In my testing it looked like the proper maximum size
> > > was being set after I loaded the drivers for the SR-IOV capable
> > > devices.
> >
> > Aha, indeed you're right.  I missed this part.  Thanks for explaining.
> >
> > So as far as I can tell it should work, I'll let others review it to
> > see if they are ok with this approach.
> 
> Ok, sure.  We'll see if Eric catches anything, he's got an eagle eye.

Having seen no further comments on this RFC I am going to clean up the patch and submit it to our internal review list for further testing and validation.  If/when it passes through that process I'll post it back here.

Thanks to all who commented and made suggestions for improvement.

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html