netdev - Re: [PATCH] Add Fujitsu 1000base-SX PCI ID to tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110601211401.GB1482@mcarlson.broadcom.com>
Date:	Wed, 1 Jun 2011 14:14:01 -0700
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"Meelis Roos" <mroos@...ee>
cc:	"Matthew Carlson" <mcarlson@...adcom.com>,
	"Michael Chan" <mchan@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Add Fujitsu 1000base-SX PCI ID to tg3

On Wed, May 25, 2011 at 08:43:47AM -0700, Meelis Roos wrote:
> This patch adds the PCI ID of Fujitsu 1000base-SX NIC to tg3 driver. 
> Tested to detect the card, MAC and serdes, not tested with link at the 
> moment since I have no fiber switch here. I did not add new constants to 
> the pci_ids.h header file since these constants are used only here.
> 
> Signed-off-by: Meelis Roos <mroos@...ux.ee>
> 
> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> index 7a5daef..7b1901e 100644
> --- a/drivers/net/tg3.c
> +++ b/drivers/net/tg3.c
> @@ -273,6 +273,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
>  	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1003)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC9100)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_TIGON3)},
> +	{PCI_DEVICE(0x10cf, 0x11a2)}, /* Fujitsu 1000base-SX with BCM5703SKHB */
>  	{}
>  };

I don't have any problems with the patch, but before we integrate it,
can we make sure it passes traffic?  I'd hate to add support for a
device and later find out it doesn't work.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html