netdev - Re: [PATCH] Add Fujitsu 1000base-SX PCI ID to tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.SOC.1.00.1106021453330.21002@math.ut.ee>
Date:	Thu, 2 Jun 2011 15:35:12 +0300 (EEST)
From:	Meelis Roos <mroos@...ux.ee>
To:	Matt Carlson <mcarlson@...adcom.com>
cc:	Michael Chan <mchan@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Add Fujitsu 1000base-SX PCI ID to tg3

> > This patch adds the PCI ID of Fujitsu 1000base-SX NIC to tg3 driver. 
> > Tested to detect the card, MAC and serdes, not tested with link at the 
> > moment since I have no fiber switch here. I did not add new constants to 
> > the pci_ids.h header file since these constants are used only here.
> > 
> > Signed-off-by: Meelis Roos <mroos@...ux.ee>
> > 
> > diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
> > index 7a5daef..7b1901e 100644
> > --- a/drivers/net/tg3.c
> > +++ b/drivers/net/tg3.c
> > @@ -273,6 +273,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
> >  	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1003)},
> >  	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC9100)},
> >  	{PCI_DEVICE(PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_TIGON3)},
> > +	{PCI_DEVICE(0x10cf, 0x11a2)}, /* Fujitsu 1000base-SX with BCM5703SKHB */
> >  	{}
> >  };
> 
> I don't have any problems with the patch, but before we integrate it,
> can we make sure it passes traffic?  I'd hate to add support for a
> device and later find out it doesn't work.

Checked with direct link to another NIC, link came up.

[   99.067432] tg3 0000:01:0b.0: eth1: Link is up at 1000 Mbps, full duplex
[   99.067662] tg3 0000:01:0b.0: eth1: Flow control is on for TX and on for RX 

I can also see DHCP requests from one interface on the other with 
tcpdump, so data gets also through. Seems to work.

-- 
Meelis Roos (mroos@...ux.ee)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html