netdev - Re: [Security] inet_diag insufficient validation?

Open Source and information security mailing list archives

Message-ID: <BANLkTin9fqYSxq4ne5hV_ri-zKeMZ9mE_g@mail.gmail.com>
Date:	Fri, 3 Jun 2011 14:55:44 +0800
From:	Eugene Teo <eugeneteo@...nel.sg>
To:	Dan Rosenberg <drosenberg@...curity.com>
Cc:	davem@...emloft.net, kuznet@....inr.ac.ru, netdev@...r.kernel.org,
	security@...nel.org, Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [Security] inet_diag insufficient validation?

Cc'ed acme.

On Wed, Jun 1, 2011 at 11:40 PM, Dan Rosenberg <drosenberg@...curity.com> wrote:
> It seems to me that the auditing performed by inet_diag_bc_audit() is
> insufficient to prevent pathological INET_DIAG bytecode from doing bad
> things.
>
> Firstly, it's possible to cause an infinite loop in inet_diag_bc_audit()
> with a INET_DIAG_BC_JMP opcode with a "yes" value of 0.  The valid_cc()
> function, also called from here, seems suspicious as well.
>
> Once the bytecode is actually run in inet_diag_bc_run(), it looks like
> more infinite loops are possible, if appropriate "yes" or "no" values
> are set to zero and weren't validated by the audit.
>
> Finally, I can't seem to find any validation that the reported length of
> the netlink message header doesn't exceed the skb length, as checked in
> some other netlink receive functions, which could result in reading
> beyond the bounds of the socket data.  I could just be missing something
> here though.
>
> Regards,
> Dan
>
> _______________________________________________
> Security mailing list
> Security@...ux.kernel.org
> http://linux.kernel.org/mailman/listinfo/security
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives