netdev - Re: [PATCHv3] net: Define enum for the bits used in features.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110604.133438.1450652272927306428.davem@davemloft.net>
Date:	Sat, 04 Jun 2011 13:34:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com, mirqus@...il.com,
	shemminger@...tta.com
Subject: Re: [PATCHv3] net: Define enum for the bits used in features.

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Wed, 25 May 2011 15:42:16 -0700

> Little bit cleanup by defining enum for all bits used. Also use those enum
> values to redefine flags.
> 
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> ---
> Changes since v2:
>  (1) Removed the include which was part of the other patch (split mishap).
>  (2) Changed the enums to add NETIF_F_ prefix.

I hate to be a pain after you've put so much work into these patches,
but I simply don't like this approach.

I think the abstracted interfaces should come first.  You don't need to
change any of the NETIF_F_* defines in order to do that.  You should only
need to add the netdev_{set,clear,test}_*() macros.

If you want you can make the "bit" argument be the flag name after the
NETIF_F_ prefix, so "netdev_test_active_feature(dev, SG)"

Then you convert every single access.

Then you make the flags type opaque, which should at that point be a
6 line change at best.

And then you can implement the flags however you want.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html