netdev - Re: Re: [PATCH kernel 3.0-rc1] smc91c92_cs: set smc->base to NULL before iounmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4999307.178051307448079250.ken_kawasaki@spring.nifty.jp>
Date:	Tue, 7 Jun 2011 21:01:19 +0900 (JST)
From:	Ken Kawasaki <ken_kawasaki@...ing.nifty.jp>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: Re: [PATCH kernel 3.0-rc1] smc91c92_cs: set smc->base to NULL before iounmap

Hi,

I will re-test this problem.

Thanks,
Ken

>> smc91c92_cs:
>>     set smc->base to NULL before iounmap
>>     to avoid writing to smc->base in smc_interrupt.
>> 
>> Signed-off-by: Ken Kawasaki <ken_kawasaki@...ing.nifty.jp>
>
>The device should be completely made quiet and all interrupts
>synchronized before unmapping chip registers.  Using NULL checks
>is merely a workaround for the real problem, even though you take
>great pains to assign NULL before the iounmap() call.
>
>Perhaps putting the pcmcia_disable_device() call before the iounmap()
>will be sufficient to fix this bug.  Or perhaps that, plus a call to
>synchronize_irq() or similar.
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html