netdev - Re: [net-next 00/12][pull request] Intel Wired LAN Driver Update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110609.005051.1530473933808285841.davem@davemloft.net>
Date:	Thu, 09 Jun 2011 00:50:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com
Subject: Re: [net-next 00/12][pull request] Intel Wired LAN Driver Update

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 09 Jun 2011 00:46:50 -0700

>> Actually, I have to un-pull.  Please build test your changes:
>> 
>> drivers/infiniband/core/netlink.c: In function ‘ibnl_rcv_msg’:
>> drivers/infiniband/core/netlink.c:151:9: error: too few arguments to function ‘netlink_dump_start’
>> include/linux/netlink.h:260:12: note: declared here
>> make[3]: *** [drivers/infiniband/core/netlink.o] Error 1
>> make[2]: *** [drivers/infiniband/core] Error 2
>> make[1]: *** [drivers/infiniband] Error 2
>> make[1]: *** Waiting for unfinished jobs....
> 
> I built tested after every patch and did not have any issues.  I see
> Greg made some changes to include/linux/netlink.h which may be the
> result of this error.

Well of course, the arguments to netlink_dump_start() changed and therefore
every call site needs to be updated.

Unless you don't have infiniband enabled in your builds, you should be
hitting this build failure too.