netdev - Re: [net-next 00/12][pull request] Intel Wired LAN Driver Update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Jun 2011 00:53:14 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: Re: [net-next 00/12][pull request] Intel Wired LAN Driver Update

On Thu, 2011-06-09 at 00:50 -0700, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Thu, 09 Jun 2011 00:46:50 -0700
> 
> >> Actually, I have to un-pull.  Please build test your changes:
> >> 
> >> drivers/infiniband/core/netlink.c: In function ‘ibnl_rcv_msg’:
> >> drivers/infiniband/core/netlink.c:151:9: error: too few arguments to function ‘netlink_dump_start’
> >> include/linux/netlink.h:260:12: note: declared here
> >> make[3]: *** [drivers/infiniband/core/netlink.o] Error 1
> >> make[2]: *** [drivers/infiniband/core] Error 2
> >> make[1]: *** [drivers/infiniband] Error 2
> >> make[1]: *** Waiting for unfinished jobs....
> > 
> > I built tested after every patch and did not have any issues.  I see
> > Greg made some changes to include/linux/netlink.h which may be the
> > result of this error.
> 
> Well of course, the arguments to netlink_dump_start() changed and therefore
> every call site needs to be updated.
> 
> Unless you don't have infiniband enabled in your builds, you should be
> hitting this build failure too.

Just did, I saw that I did not have enabled and I got the same issue.  I
am looking into now, and will check to make sure there were no other
netlink_dump_start() references missed as well.

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)