netdev - Re: Request for review on Hyper-V virtual network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1307658497.18357.6.camel@Joe-Laptop>
Date:	Thu, 09 Jun 2011 15:28:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...e.de>
Cc:	Haiyang Zhang <haiyangz@...rosoft.com>,
	Hank Janssen <hjanssen@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Request for review on Hyper-V virtual network driver

On Thu, 2011-06-09 at 15:07 -0700, Greg KH wrote:
> On Thu, Jun 09, 2011 at 09:59:19PM +0000, Haiyang Zhang wrote:
> > > -----Original Message-----
> > > From: Joe Perches [mailto:joe@...ches.com]
> > > Sent: Thursday, June 09, 2011 5:39 PM
> > > >  create mode 100644 drivers/net/hyperv/netvsc.c
> > > >  create mode 100644 drivers/net/hyperv/netvsc_drv.c
> > > >  create mode 100644 drivers/net/hyperv/rndis_filter.c
> > > >  delete mode 100644 drivers/staging/hv/hyperv_net.h
> > > >  delete mode 100644 drivers/staging/hv/netvsc.c
> > > >  delete mode 100644 drivers/staging/hv/netvsc_drv.c
> > > >  delete mode 100644 drivers/staging/hv/rndis_filter.c
> > > 
> > > I suggest you resend this using the -M or --find-renames option.
> > 
> > Will do.
> 
> No, that will not show anything at all, which is the point of the
> review.  Otherwise it will just require someone to go look at the
> drivers/staging/hv/ directory in linux-next to properly determine what
> is happening here.
> 
> So this patch is fine for a review.

The line count of the files are different.

It's much more difficult to see what if anything has changed
between the two versions.

trivia:

All the message logging uses of dev_<level> should have
a terminating newline "\n" in netvsc.c

In netvsc.c dev_<level> messages are used.
In netvsc_drv.c netdev_<level> messages are used.

int netvsc_recv_callback(struct hv_device *device_obj,
                               struct hv_netvsc_packet *packet)
{
       struct net_device *net = dev_get_drvdata(&device_obj->device);

Maybe use the netdev_<level> style everywhere possible?

It's odd and a bit ugly to use #include "../../staging/hyperv.h"

Maybe add another include path to the Makefile and just use
#include "hyperv.h"
until all of the hyperv files are moved out of staging?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html