netdev - RE: Request for review on Hyper-V virtual network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A1F3067C9B68744AA19F6802BAB8FFDC09604F3F@TK5EX14MBXC227.redmond.corp.microsoft.com>
Date:	Thu, 9 Jun 2011 22:36:55 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Joe Perches <joe@...ches.com>, Greg KH <gregkh@...e.de>
CC:	Hank Janssen <hjanssen@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: Request for review on Hyper-V virtual network driver



> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Thursday, June 09, 2011 6:28 PM
> The line count of the files are different.
> 
> It's much more difficult to see what if anything has changed
> between the two versions.

The only changes are the include file name, just to make it compile in the net dir.
After all code review suggestions are done into staging/hv, I will submit a patch
with "-M" to get the entire driver out of staging area.

> trivia:
> 
> All the message logging uses of dev_<level> should have
> a terminating newline "\n" in netvsc.c
> 
> In netvsc.c dev_<level> messages are used.
> In netvsc_drv.c netdev_<level> messages are used.
> 
> int netvsc_recv_callback(struct hv_device *device_obj,
>                                struct hv_netvsc_packet *packet)
> {
>        struct net_device *net = dev_get_drvdata(&device_obj->device);
> 
> Maybe use the netdev_<level> style everywhere possible?

Will do this change.

> 
> It's odd and a bit ugly to use #include "../../staging/hyperv.h"
> 
> Maybe add another include path to the Makefile and just use
> #include "hyperv.h"
> until all of the hyperv files are moved out of staging?

Will do.

Thanks,
- Haiyang