netdev - Re: Request for review on Hyper-V virtual network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Jun 2011 23:49:08 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg KH <gregkh@...e.de>, Haiyang Zhang <haiyangz@...rosoft.com>,
	Hank Janssen <hjanssen@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Request for review on Hyper-V virtual network driver

On Thu, 2011-06-09 at 15:28 -0700, Joe Perches wrote:
[...]
> It's odd and a bit ugly to use #include "../../staging/hyperv.h"
> 
> Maybe add another include path to the Makefile and just use
> #include "hyperv.h"
> until all of the hyperv files are moved out of staging?

It seems strange for files outside staging to have dependencies inside
staging.  I think that header file should be moved out first (or at the
same time).

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html