netdev - RE: Request for review on Hyper-V virtual network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A1F3067C9B68744AA19F6802BAB8FFDC09605F8A@TK5EX14MBXC227.redmond.corp.microsoft.com>
Date:	Thu, 9 Jun 2011 22:56:40 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	Ben Hutchings <bhutchings@...arflare.com>,
	Joe Perches <joe@...ches.com>
CC:	Greg KH <gregkh@...e.de>, Hank Janssen <hjanssen@...rosoft.com>,
	"KY Srinivasan" <kys@...rosoft.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: Request for review on Hyper-V virtual network driver

> -----Original Message-----
> From: Ben Hutchings [mailto:bhutchings@...arflare.com]
> Sent: Thursday, June 09, 2011 6:49 PM
> To: Joe Perches
> Cc: Greg KH; Haiyang Zhang; Hank Janssen; KY Srinivasan;
> shemminger@...tta.com; netdev@...r.kernel.org
> Subject: Re: Request for review on Hyper-V virtual network driver
> 
> On Thu, 2011-06-09 at 15:28 -0700, Joe Perches wrote:
> [...]
> > It's odd and a bit ugly to use #include "../../staging/hyperv.h"
> >
> > Maybe add another include path to the Makefile and just use
> > #include "hyperv.h"
> > until all of the hyperv files are moved out of staging?
> 
> It seems strange for files outside staging to have dependencies inside
> staging.  I think that header file should be moved out first (or at the
> same time).

I will request move out hyperv.h first. Actually, we already have some header
files moved out of staging before.

Thanks,
- Haiyang