netdev - Re: Request for review on Hyper-V virtual network driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110609230025.GA22856@suse.de>
Date:	Thu, 9 Jun 2011 16:00:25 -0700
From:	Greg KH <gregkh@...e.de>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Joe Perches <joe@...ches.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Hank Janssen <hjanssen@...rosoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"shemminger@...tta.com" <shemminger@...tta.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: Request for review on Hyper-V virtual network driver

On Thu, Jun 09, 2011 at 11:49:08PM +0100, Ben Hutchings wrote:
> On Thu, 2011-06-09 at 15:28 -0700, Joe Perches wrote:
> [...]
> > It's odd and a bit ugly to use #include "../../staging/hyperv.h"
> > 
> > Maybe add another include path to the Makefile and just use
> > #include "hyperv.h"
> > until all of the hyperv files are moved out of staging?
> 
> It seems strange for files outside staging to have dependencies inside
> staging.  I think that header file should be moved out first (or at the
> same time).

The hyperv core hasn't moved out yet, as there is other work happening
there first.  I think Haiyang wanted to find out what was left to do on
the network driver side first while others work on the core issues.

So you can safely ignore that include for now, it's not a big deal, this
isn't ready to be merged yet, that's what the review is for :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html