netdev - RE: [Pv-drivers] [PATCH] vmxnet3: remove unused variable

Open Source and information security mailing list archives

Message-ID: <382C2929804A6B469FF4A4200E716F480431EFCC7587@EXCH-MBX-1.vmware.com>
Date:	Mon, 13 Jun 2011 10:10:56 -0700
From:	Bhavesh Davda <bhavesh@...are.com>
To:	Neil Horman <nhorman@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"VMware, Inc." <pv-drivers@...are.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: RE: [Pv-drivers] [PATCH] vmxnet3: remove unused variable

Good find. LGTM.

Signed-off-by: Bhavesh Davda <bhavesh@...are.com>

- Bhavesh

Bhavesh P. Davda

> -----Original Message-----
> From: pv-drivers-bounces@...are.com [mailto:pv-drivers-bounces@...are.com] On
> Behalf Of Neil Horman
> Sent: Monday, June 13, 2011 8:49 AM
> To: netdev@...r.kernel.org
> Cc: VMware, Inc.; David S. Miller; Neil Horman
> Subject: [Pv-drivers] [PATCH] vmxnet3: remove unused variable
> 
> While doing some backporting I noticed that vmxnet3 had a variable that was
> set
> but never used.  Get rid of it, and stop the compiler from griping
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> CC: "VMware, Inc." <pv-drivers@...are.com>
> CC: "David S. Miller" <davem@...emloft.net>
> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index fa6e2ac..a9b60a2 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -405,10 +405,8 @@ vmxnet3_tq_cleanup(struct vmxnet3_tx_queue *tq,
> 
>  	while (tq->tx_ring.next2comp != tq->tx_ring.next2fill) {
>  		struct vmxnet3_tx_buf_info *tbi;
> -		union Vmxnet3_GenericDesc *gdesc;
> 
>  		tbi = tq->buf_info + tq->tx_ring.next2comp;
> -		gdesc = tq->tx_ring.base + tq->tx_ring.next2comp;
> 
>  		vmxnet3_unmap_tx_buf(tbi, adapter->pdev);
>  		if (tbi->skb) {
> --
> 1.7.5.4
> 
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@...are.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives