netdev - Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimdj-p9a+615JPe6oUJQqQo4_+-rA@mail.gmail.com>
Date:	Tue, 14 Jun 2011 10:18:12 +0200
From:	Daniele Venzano <venza@...wnhat.org>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Jay Cliburn <jcliburn@...il.com>,
	Chris Snook <chris.snook@...il.com>,
	Jie Yang <jie.yang@...eros.com>,
	Sathya Perla <sathya.perla@...lex.com>,
	Subbu Seetharaman <subbu.seetharaman@...lex.com>,
	Ajit Khaparde <ajit.khaparde@...lex.com>,
	Rasesh Mody <rmody@...cade.com>,
	Debashis Dutt <ddutt@...cade.com>,
	Sjur Braendeland <sjur.brandeland@...ricsson.com>,
	Divy Le Ray <divy@...lsio.com>,
	Breno Leitao <leitao@...ux.vnet.ibm.com>,
	Amit Kumar Salecha <amit.salecha@...gic.com>,
	Ron Mercer <ron.mercer@...gic.com>, linux-driver@...gic.com,
	Anirban Chakraborty <anirban.chakraborty@...gic.com>,
	Jon Mason <jdmason@...zu.us>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	Steve Hodgson <shodgson@...arflare.com>,
	Ben Hutchings <bhutchings@...arflare.com>,
	David Dillow <dave@...dillows.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *

2011/6/14 Joe Perches <joe@...ches.com>:
> Unnecessary casts of void * clutter the code.

> diff --git a/drivers/net/sis900.c b/drivers/net/sis900.c
> index 484f795..658a192 100644
> --- a/drivers/net/sis900.c
> +++ b/drivers/net/sis900.c
> @@ -482,7 +482,7 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
>                ret = -ENOMEM;
>                goto err_out_cleardev;
>        }
> -       sis_priv->tx_ring = (BufferDesc *)ring_space;
> +       sis_priv->tx_ring = ring_space;
>        sis_priv->tx_ring_dma = ring_dma;
>
>        ring_space = pci_alloc_consistent(pci_dev, RX_TOTAL_SIZE, &ring_dma);
> @@ -490,7 +490,7 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
>                ret = -ENOMEM;
>                goto err_unmap_tx;
>        }
> -       sis_priv->rx_ring = (BufferDesc *)ring_space;
> +       sis_priv->rx_ring = ring_space;
>        sis_priv->rx_ring_dma = ring_dma;
>
>        /* The SiS900-specific entries in the device structure. */

sis900 looks good, too.

-- 
Daniele Venzano
venza@...wnhat.org
http://www.brownhat.org
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html