netdev - Re: [PATCH] tun: teach the tun/tap driver to support netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2011 09:44:39 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Neil Horman <nhorman@...driver.com>
CC:	netdev@...r.kernel.org, Rik van Riel <riel@...hat.com>,
	Maxim Krasnyansky <maxk@...lcomm.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] tun: teach the tun/tap driver to support netpoll

于 2011年06月15日 23:25, Neil Horman 写道:
> Commit 8d8fc29d02a33e4bd5f4fa47823c1fd386346093 changed the behavior of slave
> devices in regards to netpoll.  Specifically it created a mutually exclusive
> relationship between being a slave and a netpoll-capable device.  This creates
> problems for KVM because guests relied on needing netconsole active on a slave
> device to a bridge.  Ideally libvirtd could just attach netconsole to the bridge
> device instead, but thats currently infeasible, because while the bridge device
> supports netpoll, it requires that all slave interface also support it, but the
> tun/tap driver currently does not.  The most direct solution is to teach tun/tap
> to support netpoll, which is implemented by the patch below.
>

Yeah, bridge checks if all the underlying devices support netpoll,
that is why Rik saw the failure.


> I've not tested this yet, but its pretty straightforward.
>
> Signed-off-by: Neil Horman<nhorman@...driver.com>
> Reported-by: Rik van Riel<riel@...hat.com>
> CC: Rik van Riel<riel@...hat.com>
> CC: Maxim Krasnyansky<maxk@...lcomm.com>
> CC: Cong Wang<amwang@...hat.com>
> CC: "David S. Miller"<davem@...emloft.net>

Reviewed-by: WANG Cong <amwang@...hat.com>

Thanks for fixing it!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html