netdev - Re: [PATCH] tun: teach the tun/tap driver to support netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110616.235334.1805823535607900944.davem@davemloft.net>
Date:	Thu, 16 Jun 2011 23:53:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, riel@...hat.com, maxk@...lcomm.com,
	amwang@...hat.com
Subject: Re: [PATCH] tun: teach the tun/tap driver to support netpoll

From: Neil Horman <nhorman@...driver.com>
Date: Wed, 15 Jun 2011 11:25:01 -0400

> Commit 8d8fc29d02a33e4bd5f4fa47823c1fd386346093 changed the behavior of slave
> devices in regards to netpoll.  Specifically it created a mutually exclusive
> relationship between being a slave and a netpoll-capable device.  This creates
> problems for KVM because guests relied on needing netconsole active on a slave
> device to a bridge.  Ideally libvirtd could just attach netconsole to the bridge
> device instead, but thats currently infeasible, because while the bridge device
> supports netpoll, it requires that all slave interface also support it, but the
> tun/tap driver currently does not.  The most direct solution is to teach tun/tap
> to support netpoll, which is implemented by the patch below.
> 
> I've not tested this yet, but its pretty straightforward.
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> Reported-by: Rik van Riel <riel@...hat.com>
> CC: Rik van Riel <riel@...hat.com>
> CC: Maxim Krasnyansky <maxk@...lcomm.com>
> CC: Cong Wang <amwang@...hat.com>
> CC: "David S. Miller" <davem@...emloft.net>

Applied, thanks Neil.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html