netdev - Re: [PATCH net-next 3/3] udp/recvmsg: Clear MSG_TRUNC flag when starting over for a new packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1308721438.2713.6.camel@edumazet-laptop>
Date:	Wed, 22 Jun 2011 07:43:58 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Xufeng Zhang <xufeng.zhang@...driver.com>
Subject: Re: [PATCH net-next 3/3] udp/recvmsg: Clear MSG_TRUNC flag when
 starting over for a new packet

Le mardi 21 juin 2011 à 16:43 -0400, Paul Gortmaker a écrit :
> From: Xufeng Zhang <xufeng.zhang@...driver.com>
> 
> Consider this scenario: When the size of the first received udp packet
> is bigger than the receive buffer, MSG_TRUNC bit is set in msg->msg_flags.
> However, if checksum error happens and this is a blocking socket, it will
> goto try_again loop to receive the next packet.  But if the size of the
> next udp packet is smaller than receive buffer, MSG_TRUNC flag should not
> be set, but because MSG_TRUNC bit is not cleared in msg->msg_flags before
> receive the next packet, MSG_TRUNC is still set, which is wrong.
> 
> Fix this problem by clearing MSG_TRUNC flag when starting over for a
> new packet.
> 
> Signed-off-by: Xufeng Zhang <xufeng.zhang@...driver.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  net/ipv4/udp.c |    3 +++
>  net/ipv6/udp.c |    3 +++
>  2 files changed, 6 insertions(+), 0 deletions(-)

Acked-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html