netdev - Re: [RFC 02/72] 3c*/acenic/typhoon: Move 3Com Ethernet drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110628092212.37708ca7@bob.linux.org.uk>
Date:	Tue, 28 Jun 2011 09:22:12 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Philip Blundell <philb@....org>,
	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>,
	David Dillow <dave@...dillows.org>,
	Jes Sorensen <jes@...ined-monkey.org>,
	Donald Becker <becker@...ld.com>,
	Craig Southeren <craigs@...luki.apana.org.au>,
	David Hinds <dahinds@...rs.sourceforge.net>
Subject: Re: [RFC 02/72] 3c*/acenic/typhoon: Move 3Com Ethernet drivers

On Sat, 25 Jun 2011 06:58:13 -0700
Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:

> Moves the 3Com drivers into drivers/net/ethernet/3com/ and the
> necessary Kconfig and Makefile changes.

This seems a bizarre way to carve stuff up.

To start with several of the things you put in 3com are just branded
items, or are boards using non 3com devices which are currently with
the other drivers that do so, some even use shared midlayers that you
move them away from.

You also pull stuff out of pcmcia which makes it harder to scan stuff
grouped logically.

So this all seems a bit daft to me.

Surely it would make sense to put all the Intel 825xx stuff together,
all the 8390 stuff together and so on.

Alan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html