netdev - RE: [PATCH] [net][bna] Fix call trace when interrupts are disabled while sleeping function kzalloc is called

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86A82D66F5E5@HQ1-EXCH01.corp.brocade.com>
Date:	Tue, 28 Jun 2011 10:27:55 -0700
From:	Rasesh Mody <rmody@...cade.com>
To:	"Shyam_Iyer@...l.com" <Shyam_Iyer@...l.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"shyam.iyer.t@...il.com" <shyam.iyer.t@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Debashis Dutt <ddutt@...cade.COM>,
	Jing Huang <huangj@...cade.COM>
Subject: RE: [PATCH] [net][bna] Fix call trace when interrupts are disabled
 while sleeping function kzalloc is called

>From: Shyam_Iyer@...l.com [mailto:Shyam_Iyer@...l.com]
>Sent: Tuesday, June 28, 2011 9:30 AM
>
>Here is try 2.
>
>I found that I had to initialize the flags variable outside the
>spin_lock_irqsave in the following way to fix the problem. The sleeping
>kzalloc function is in fact in the request_threaded_irq call which
>allocates the irq handler function and its flags arguments.
>
>Attached patch fixes the issue.

The attached patch may fix the issue in MSIX mode, however we'll continue to see the issue in INTX mode. Using a separate irq_flags may be a good idea.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html