netdev - RE: [PATCH] [net][bna] Fix call trace when interrupts are disabled while sleeping function kzalloc is called

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DBFB1B45AF80394ABD1C807E9F28D1570453626FF2@BLRX7MCDC203.AMER.DELL.COM>
Date:	Tue, 28 Jun 2011 11:48:26 -0700
From:	<Shyam_Iyer@...l.com>
To:	<rmody@...cade.com>, <davem@...emloft.net>,
	<shyam.iyer.t@...il.com>
CC:	<netdev@...r.kernel.org>, <ddutt@...cade.COM>, <huangj@...cade.COM>
Subject: RE: [PATCH] [net][bna] Fix call trace when interrupts are disabled
 while sleeping function kzalloc is called



> -----Original Message-----
> From: Rasesh Mody [mailto:rmody@...cade.com]
> Sent: Tuesday, June 28, 2011 1:28 PM
> To: Iyer, Shyam; davem@...emloft.net; shyam.iyer.t@...il.com
> Cc: netdev@...r.kernel.org; Debashis Dutt; Jing Huang
> Subject: RE: [PATCH] [net][bna] Fix call trace when interrupts are
> disabled while sleeping function kzalloc is called
> 
> >From: Shyam_Iyer@...l.com [mailto:Shyam_Iyer@...l.com]
> >Sent: Tuesday, June 28, 2011 9:30 AM
> >
> >Here is try 2.
> >
> >I found that I had to initialize the flags variable outside the
> >spin_lock_irqsave in the following way to fix the problem. The
> sleeping
> >kzalloc function is in fact in the request_threaded_irq call which
> >allocates the irq handler function and its flags arguments.
> >
> >Attached patch fixes the issue.
> 
> The attached patch may fix the issue in MSIX mode, however we'll
> continue to see the issue in INTX mode. Using a separate irq_flags may
> be a good idea.

You are right.. Resending another version.
-Shyam
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html