netdev - Re: coding style question on indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1309533793.7277.51.camel@Joe-Laptop>
Date:	Fri, 01 Jul 2011 08:23:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sathya.Perla@...lex.Com
Cc:	netdev@...r.kernel.org
Subject: Re: coding style question on indentation

On Fri, 2011-07-01 at 04:20 -0700, Sathya.Perla@...lex.Com wrote:
> a) Aligning the next line with the first argument by inserting a few spaces after the tabs - as in:
> 
> 	dma_unmap_page(&adapter->pdev->dev,
> 			   dma_unmap_addr(rx_page_info, bus),
> 			   adapter->big_page_size, DMA_FROM_DEVICE);

My preference as well, but your example may not be correct.

I think this better:

         1         2         3         4         5         6         7         8
12345678901234567890123456789012345678901234567890123456789012345678901234567890

	dma_unmap_page(&adapter->pdev->dev, dma_unmap_addr(rx_page_info, bus),
		       adapter->big_page_size, DMA_FROM_DEVICE);

maximally fill to 80 cols, then wrap with maximal tabs using spaces
if necessary to align args after opening parenthesis.
In this case, 2 tabs, 7 spaces.

It is your code though, do what you think best.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html