netdev - Re: coding style question on indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Jul 2011 13:54:52 -0600
From:	Chris Friesen <chris.friesen@...band.com>
To:	Joe Perches <joe@...ches.com>
CC:	Sathya.Perla@...lex.Com, netdev@...r.kernel.org
Subject: Re: coding style question on indentation

On 07/01/2011 09:23 AM, Joe Perches wrote:

> I think this better:
>
>           1         2         3         4         5         6         7         8
> 12345678901234567890123456789012345678901234567890123456789012345678901234567890
>
> 	dma_unmap_page(&adapter->pdev->dev, dma_unmap_addr(rx_page_info, bus),
> 		       adapter->big_page_size, DMA_FROM_DEVICE);
>
> maximally fill to 80 cols, then wrap with maximal tabs using spaces
> if necessary to align args after opening parenthesis.
> In this case, 2 tabs, 7 spaces.

I think the most flexible is to use hard tabs to align the continued 
line to the same level of indentation as the parent line, then use 
spaces for "pretty" alignment.  That way, it all lines up regardless of 
how many spaces the viewer has set for the equivalent size of hard tabs.

Chris

-- 
Chris Friesen
Software Developer
GENBAND
chris.friesen@...band.com
www.genband.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html