netdev - Re: [rfc] Remove member .name from struct netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E112044.8050904@redhat.com>
Date:	Mon, 04 Jul 2011 10:07:00 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Joe Perches <joe@...ches.com>
CC:	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Matt Mackall <mpm@...enic.com>
Subject: Re: [rfc] Remove member .name from struct netpoll

于 2011年07月02日 01:07, Joe Perches 写道:
> struct netpoll has member .name
>
> struct netpoll {
> 	struct net_device *dev;
> 	char dev_name[IFNAMSIZ];
> 	const char *name;
> [...]
> };
>
> that is set only by netconsole.c
>
> static struct netconsole_target *alloc_param_target(char *target_config)
> {
> [...]
> 	nt->np.name = "netconsole";
>
> and used only by net/core/netpoll.c to emit "netconsole: " on
> logging messages.
>

Probably this is due to that in history netdump was another user of it.

>
> Are there out of tree users or plans to use "struct netpoll"
> by other modules?
>

AFAIK, netoops will use it too, see
https://lkml.org/lkml/2010/11/2/299

Cc'ing Matt in case I miss something...

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html