netdev - Re: [PATCH] net: 8139too: Initial necessary vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110703.195423.1809799333507901972.davem@davemloft.net>
Date:	Sun, 03 Jul 2011 19:54:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	shanwei@...fujitsu.com, netdev@...r.kernel.org,
	adobriyan@...il.com, tj@...nel.org
Subject: Re: [PATCH] net: 8139too: Initial necessary vlan_features to
 support vlan

From: Francois Romieu <romieu@...zoreil.com>
Date: Sat, 2 Jul 2011 11:51:38 +0200

> Shan Wei <shanwei@...fujitsu.com> :
>> Offload setting of vlan device requires
>> vlan_features to be initialed.
> [...]
>> @@ -993,6 +993,7 @@ static int __devinit rtl8139_init_one (struct pci_dev *pdev,
>>  	 * features
>>  	 */
>>  	dev->features |= NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_HIGHDMA;
>> +	dev->vlan_features = dev->features;
> 
>         /* note: the hardware is not capable of sg/csum/highdma, however
>          * through the use of skb_copy_and_csum_dev we enable these
>          * features
>          */
> 
> The commit message is a bit misleading wrt hardware capabilities but the
> patch makes sense.
> 
> Acked-by: Francois Romieu <romieu@...zoreil.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html