netdev - RE: [PATCH RFC] igb: Fix false positive return of igb_get_auto_rd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <EDC0E76513226749BFBC9C3FB031318F0172619A6A@orsmsx508.amr.corp.intel.com>
Date:	Wed, 6 Jul 2011 08:28:03 -0700
From:	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>
To:	Guenter Roeck <guenter.roeck@...csson.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Tong Ho <tong.ho@...csson.com>
Subject: RE: [PATCH RFC] igb: Fix false positive return of
 igb_get_auto_rd_done for 82580



>-----Original Message-----
>From: Guenter Roeck [mailto:guenter.roeck@...csson.com]
>Sent: Tuesday, July 05, 2011 7:31 AM
>To: Kirsher, Jeffrey T
>Cc: Brandeburg, Jesse; Wyborny, Carolyn; Duyck, Alexander H; Ronciak,
>John; e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org; Tong Ho
>Subject: Re: [PATCH RFC] igb: Fix false positive return of
>igb_get_auto_rd_done for 82580
>
>On Tue, Jun 21, 2011 at 05:17:26PM -0400, Jeff Kirsher wrote:
>> On Tue, 2011-06-21 at 12:02 -0700, Guenter Roeck wrote:
>> > From: Tong Ho <tong.ho@...csson.com>
>> >
>> > 82580 re-reads the port specific portion of eeprom after port reset.
>> > If called immediately after a reset, igb_get_auto_rd_done() returns
>> > false positive because the done bit has yet to transition from 1 to
>0.
>> >
>> > Add wrfl() immediately after resetting 82580 port or device,
>> > plus a 1ms delay, to avoid the problem.
>> >
>> > Signed-off-by: Tong Ho <tong.ho@...csson.com>
>> > Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com>
>> > ---
>> > Sent as RFC since I am not entirely sure if the solution is the
>> > correct one
>> > to address the problem we are seeing. If there is a better solution,
>> > please
>> > let me know.
>>
>> Thank you for the suggested patch.  Carolyn is the maintainer for igb
>> and we will look into this issue you are seeing and the suggested fix.
>
>Hi Jeff and Carolyn,
>
>Any update ?
>
>Thanks,
>Guenter

Sorry for the delay, we've had some holidays, its just passed internal testing and should be coming upstream shortly.

Thanks,

Carolyn

Carolyn Wyborny
Linux Development
LAN Access Division
Intel Corporation


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html